triage: P-low I believe most cleanup here has been done and the leftover `__` are either implementation details or either aspects of hygiene which haven't been implemented yet, so I no longer think this is a backwards-compatibility problem for libraries.
triage: P-high (1.0)
triage: P-backcompat-libs (1.0)
@alexcrichton You've raised some excellent points -- in particular about scoring not being as usable as one might imagine at first. I'm going to take this off the milestone; I think the `sort_by` API, which is stable, is fine. We can work out exactly which API to use for `max_by`/`min_by` when we stabilize them, but there's not a great deal of pressure to stabilize them right this second. triage: P-high ()
triage: P-high ()
e.g., ``` mod B { pub use self::A::foo; mod A { pub struct X; pub fn foo(_: X) {} } } ``` From outside `B`, `foo` is visible, but `X` is not. The fix is discussed [here](https://github.com/rust-lang/rust/issues/22261#issuecomment-78204761) and in the following comments. I guess this is technically a backwards incompatible change, but I would regard any example of it as a bug, so I would not feel bad fixing this post 1.0 (also the fix is really easy if we do break your code - just add `pub`). Still, nominating triage: I-nominated (example by @tomaka from #23585)
triage: I-nominated